Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ana/make close during sign in close straight #3283

Merged
merged 5 commits into from
Dec 11, 2019

Conversation

Bitcoinera
Copy link
Contributor

Closes #ISSUE
This button is something I added myself, so I just fixed it (plus it is only two lines of code)

Description:

Earlier the signin close button was only taking you to the previous modal.
Really silly behavior (my bad 😅 ).
Now it takes you directly to root (/)!

The only thing I see a bit annoying is that it is a bit slow. If anyone knows a way to make it faster, I'd appreciate.

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

/>
<a class="user-box" @click="goBack">
<a class="user-box" href="/">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use @click.native="$router.push(/)"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants